This repository has been archived by the owner on Oct 18, 2022. It is now read-only.
Don't use reqwest::blocking resolves #60 #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ict-cloud
changed the title
modified: Cargo.toml
from async to result
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jonas
This is a working minimal version without any noticeable regressions for the elimination of reqwest::blocking.
I have refactored the transport implementation to use reqwest and used tokio Runtime (in order to avoid additional dependencies) to execute the blocking thread. As a return value I chose the Cursor which lefts the trait untouched and can be properly handled.
I also updated to the 2021 syntax and upgraded some of the dependencies.
I hope you find all the necessary work done properly (this is my firs PR for a Rust crate). Otherwise let me know if I need to change anything.
Best
P